[ 
https://issues.apache.org/jira/browse/YARN-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832595#comment-13832595
 ] 

Tsuyoshi OZAWA commented on YARN-1239:
--------------------------------------

[~jianhe], maybe RMStateVersionIncompatibleException file seems to be missing 
in your latest patch.

One trivial point:
{code}
-  optional int64 start_time = 2;
-  optional ApplicationSubmissionContextProto application_submission_context = 
3;
-  optional string user = 4;
+  optional ApplicationSubmissionContextProto application_submission_context = 
2;
+  optional string user = 3;
+  optional int64 start_time = 4;
{code}

I think we should not swap these fields unless we think it's reasonable.



> Save version information in the state store
> -------------------------------------------
>
>                 Key: YARN-1239
>                 URL: https://issues.apache.org/jira/browse/YARN-1239
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Bikas Saha
>            Assignee: Jian He
>         Attachments: YARN-1239.1.patch, YARN-1239.2.patch, YARN-1239.3.patch, 
> YARN-1239.4.patch, YARN-1239.4.patch, YARN-1239.5.patch, YARN-1239.6.patch, 
> YARN-1239.7.patch, YARN-1239.patch
>
>
> When creating root dir for the first time we should write version 1. If root 
> dir exists then we should check that the version in the state store matches 
> the version from config.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to