[
https://issues.apache.org/jira/browse/YARN-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337438#comment-17337438
]
Szilard Nemeth commented on YARN-10628:
---------------------------------------
Hi [~ananyo_rao],
In general, patch looks good. I have some suggestions, though.
1. In class NodeUsageRanges:
Please add a javadoc. For example, it would be good to know if the upper bound
of the range is inclusive or not.
2. In
org.apache.hadoop.yarn.sls.scheduler.SchedulerMetrics#registerNodesUsageMetrics:
The logic that updates that gathers the memory / vcores stats is duplicated.
The only difference is the method that is called on the Resource (either
'getVirtualCores' or 'getMemorySize').
Can you make this cleaner by extracting the logic into one method?
3. In org.apache.hadoop.yarn.sls.web.SLSWebApp#generateRealTimeTrackingMetrics:
It's minor but there's still a bit of a code duplication here.
Can you introduce a method that updates the any gauge map (let it be vcores or
memory) with a specified key, e.g. "nodes.vcores.<keyword>" where keyword will
be references from the Range object?
Similarly, another method could be extracted that gets the value from the same
maps, according to the keyword that comes from the Range object.
> Add node usage metrics in SLS
> -----------------------------
>
> Key: YARN-10628
> URL: https://issues.apache.org/jira/browse/YARN-10628
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler-load-simulator
> Affects Versions: 3.3.1
> Reporter: VADAGA ANANYO RAO
> Assignee: VADAGA ANANYO RAO
> Priority: Major
> Attachments: Nodes_memory_usage.png, Nodes_vcores_usage.png,
> YARN-10628.0001.patch, YARN-10628.0002.patch, YARN-10628.0003.patch
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Given the work around container packing going on in YARN schedulers, it would
> be beneficial to have charts showing the usage per node in SLS. This will
> help to improve container packing algorithms for more efficient packings.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
