[ 
https://issues.apache.org/jira/browse/YARN-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337446#comment-17337446
 ] 

Szilard Nemeth commented on YARN-10663:
---------------------------------------

Hi [~ananyo_rao],
Change looks good to me.
One small ask: Could you please add tests to the AMSimulator? 
I can't see the mentioned logic tested anywhere: 
{quote}
When the app is finishing, for each node in ranNodes list in AMSimulator, we 
will remove the app from the runningApps list of that node.
{quote}

Please also note that I have set this to patch available status so jenkins will 
trigger.

> Add runningApps stats in SLS
> ----------------------------
>
>                 Key: YARN-10663
>                 URL: https://issues.apache.org/jira/browse/YARN-10663
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: yarn
>            Reporter: VADAGA ANANYO RAO
>            Assignee: VADAGA ANANYO RAO
>            Priority: Major
>         Attachments: YARN-10663.0001.patch
>
>
> RMNodes in SLS don't keep a track of runningApps on each node. Due to this, 
> graceful decommissioning logic takes a hit as the nodes will decommission if 
> there are no running containers on the node but some shuffle data was present 
> on the node.
> In this Jira, we will add runningApps functionality in SLS for improving 
> decommissioning logic of each node. This will help with autoscaling 
> simulations on SLS.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to