[
https://issues.apache.org/jira/browse/YARN-10761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340347#comment-17340347
]
Eric Badger commented on YARN-10761:
------------------------------------
Thanks for the patch, [~zhuqi].
Is there a reason we need to call {{create()}} twice for each metric? The code
in the patch calls it onceee to create the {{GenericEventTypeMetricsManager}}
and then again just so that it can call {{getEnumClass()}}. Seems better to
save the first {{create()}} call off into a local variable and then call
{{getEnumClass()}} on that so we don't have to call {{create()}} twice per
metric
> Add more event type to RM Dispatcher event metrics.
> ---------------------------------------------------
>
> Key: YARN-10761
> URL: https://issues.apache.org/jira/browse/YARN-10761
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Qi Zhu
> Assignee: Qi Zhu
> Priority: Major
> Attachments: YARN-10761.001.patch, image-2021-05-06-16-38-51-406.png,
> image-2021-05-06-16-39-28-362.png
>
>
> Since YARN-9615 add NodesListManagerEventType to event metrics.
> And we'd better add total 4 busy event type to the metrics according to
> YARN-9927.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
