[
https://issues.apache.org/jira/browse/YARN-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341916#comment-17341916
]
Benjamin Teke commented on YARN-10759:
--------------------------------------
Thanks for working on this [~gandras]! The change in general looks good to me,
it does make things simpler. I have one question/suggestion:
While currently this isn't necessary, but in ManagedParentQueue the mode checks
are a bit long:
{code:java}
if(this.capacityConfigType.equals(AbstractCSQueue.CapacityConfigType.PERCENTAGE)
{...}
{code}
If these will be used elsewhere in the future it might be a bit cleaner to add
the checker methods to capacityConfigType for each type. For example:
this.capacityConfigType.isAbsolute(), this.capacityConfigType.isRelative(),
this.capacityConfigType.isWeight().
> Encapsulate queue config modes
> ------------------------------
>
> Key: YARN-10759
> URL: https://issues.apache.org/jira/browse/YARN-10759
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: capacity scheduler
> Reporter: Andras Gyori
> Assignee: Andras Gyori
> Priority: Major
> Attachments: YARN-10759.001.patch, YARN-10759.002.patch,
> YARN-10759.003.patch
>
>
> Capacity Scheduler queues have three modes:
> * relative/percentage
> * weight
> * absolute
> Most of them have their own:
> * validation logic
> * config setting logic
> * effective capacity calculation logic
> These logics can be easily extracted and encapsulated in separate config mode
> classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
