[ 
https://issues.apache.org/jira/browse/YARN-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833497#comment-13833497
 ] 

Mayank Bansal commented on YARN-967:
------------------------------------

Thanks [~vinodkv] for review.

bq. Throughout the patch: Check and wrap lines longer than 80 characters
Done
bq. Audience and visibility annotations missing for 
ApplicationNotFoundException, ApplicationAttemptNotFoundException and 
ContainerNotFoundException
Done
bq. Fix javadoc for getContainerReport() etc: they shouldn't have client token 
etc among other things. Please go through the remaining methods too.
Done
bq. Create and use newInstance methods in GetApplicationReportRequest, 
GetApplicationAttemptReportRequest and GetContainerReportRequest
Donw
bq. Why is the container-state null in the test? Use an appropriate state.
Done
bq.If you've tested this on a single node, can you paste the command and output 
for each of the new command on the CLI?
{code}
LM-SJN-00712655:hadoop-2.3.0-SNAPSHOT mabansal$ bin/yarn application -status 
application_1385531405126_0001
13/11/26 21:55:53 WARN util.NativeCodeLoader: Unable to load native-hadoop 
library for your platform... using builtin-java classes where applicable
13/11/26 21:55:54 INFO client.RMProxy: Connecting to ResourceManager at 
/0.0.0.0:8032
13/11/26 21:55:54 INFO client.AHSProxy: Connecting to Application History 
server at /0.0.0.0:10200
Application Report : 
        Application-Id : application_1385531405126_0001
        Application-Name : word count
        Application-Type : MAPREDUCE
        User : mabansal
        Queue : default
        Start-Time : 1385531699120
        Finish-Time : 0
        Progress : 50%
        State : RUNNING
        Final-State : UNDEFINED
        Tracking-URL : http://LM-SJN-00712655:64778
        RPC Port : 64777
        AM Host : LM-SJN-00712655
        Diagnostics : 

13/11/26 22:00:30 INFO client.AHSProxy: Connecting to Application History 
server at /0.0.0.0:10200
Application Attempt Report : 
        ApplicationAttempt-Id : appattempt_1385531405126_0001_000001
        State : null
        AMContainer : container_1385531405126_0001_01_000001
        Tracking-URL : 
http://LM-SJN-00712655:8088/proxy/application_1385531405126_0001/jobhistory/job/job_1385531405126_0001
        RPC Port : 64777
        AM Host : LM-SJN-00712655
        Diagnostics : 

LM-SJN-00712655:hadoop-2.3.0-SNAPSHOT mabansal$ bin/yarn container -status 
container_1385531405126_0001_01_000001
13/11/26 22:01:18 WARN util.NativeCodeLoader: Unable to load native-hadoop 
library for your platform... using builtin-java classes where applicable
13/11/26 22:01:18 INFO client.RMProxy: Connecting to ResourceManager at 
/0.0.0.0:8032
13/11/26 22:01:18 INFO client.AHSProxy: Connecting to Application History 
server at /0.0.0.0:10200
Container Report : 
        Container-Id : container_1385531405126_0001_01_000001
        Start-Time : 1385531699937
        Finish-Time : 1385531771189
        State : COMPLETE
        LOG-URL : 
http://192.168.0.193:8042/node/containerlogs/container_1385531405126_0001_01_000001/mabansal
        Host : 192.168.0.193:64620
        Diagnostics : 

{code}

> [YARN-321] Command Line Interface(CLI) for Reading Application History 
> Storage Data
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-967
>                 URL: https://issues.apache.org/jira/browse/YARN-967
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Devaraj K
>            Assignee: Mayank Bansal
>         Attachments: YARN-967-1.patch, YARN-967-2.patch, YARN-967-3.patch, 
> YARN-967-4.patch, YARN-967-5.patch, YARN-967-6.patch, YARN-967-7.patch, 
> YARN-967-8.patch, YARN-967-9.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to