[ 
https://issues.apache.org/jira/browse/YARN-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355122#comment-17355122
 ] 

Gergely Pollák commented on YARN-10797:
---------------------------------------

[~snemeth] thank you for the patch! LGTM+1 (Binding)

There are no new tests needed, since you only changed a few log messages, 
committing this in.

> Logging parameter issues in scheduler package
> ---------------------------------------------
>
>                 Key: YARN-10797
>                 URL: https://issues.apache.org/jira/browse/YARN-10797
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Minor
>         Attachments: YARN-10797.001.patch
>
>
> 1. There is a LOG.error call in 
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.QueueConfigurationAutoRefreshPolicy#editSchedule
>  that provides logging arguments without a placeholder in the message.
> {code}
>   LOG.error("Failed to reload capacity scheduler config file - " +
>                 "will use existing conf.", e.getMessage());
> {code}
> 2. There is a LOG.debug call in 
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp#moveReservation
>  that has a placeholder in the logging message but the argument is an 
> instance of Throwable so the message does not require a placeholder.
> {code}
>  } catch (IllegalStateException e) {
>     LOG.debug("Reserve on target node failed, e={}", e);
>     return false;
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to