[
https://issues.apache.org/jira/browse/YARN-10801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355812#comment-17355812
]
Benjamin Teke commented on YARN-10801:
--------------------------------------
[~gandras] thanks for working on this! An idea for the patch:
The necessity of setting both the "oldConfiguration" and the "newConfiguration"
comes from the fact that the configuration object is copied in
_ParentQueue#getConfForAutoCreatedQueue_. That method duplicates the
configuration because two properties are modified for dynamic leaf queues. This
however introduces the possibility for similar errors down the line, where the
caller isn't aware of this duplication. I think it would keep things simpler
and prevent future issues like this if those two properties would be set for
the queue if the queue is dynamic without creating an extra configuration
object and passing it along. What do you think?
> Fix Auto Queue template to properly set all configuration properties
> --------------------------------------------------------------------
>
> Key: YARN-10801
> URL: https://issues.apache.org/jira/browse/YARN-10801
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Andras Gyori
> Assignee: Andras Gyori
> Priority: Major
> Attachments: YARN-10801.001.patch
>
>
> Currently Auto Queue templates set configuration properties only on
> Configuration object passed in the constructor. Due to the fact, that a lot
> of configuration values are ready from the Configuration object in csContext,
> template properties are not set in every cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
