[ 
https://issues.apache.org/jira/browse/YARN-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13834382#comment-13834382
 ] 

Binglin Chang commented on YARN-1450:
-------------------------------------

bq. So, if we launch the AM with --shell_command, we will meet the same issue 
as before (can not allow multiple commands separating with ";" or "|"). Right ?
Actually there is no issue, the AM is started standalone(no client -> RM -> NM 
-> launch AM), we don't need to care about escaping/unescaping issues, allow 
multiple commands separating with ";", ";", "|" or env variable should be fine. 
There is nothing wrong about --shell_command, anything you can write to a file 
you can pass with cmdline, the issue in YARN-1303 is cuased by client try to 
construct a whole cmd without proper escaping support. 

> TestUnmanagedAMLauncher#testDSShell fails on trunk
> --------------------------------------------------
>
>                 Key: YARN-1450
>                 URL: https://issues.apache.org/jira/browse/YARN-1450
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications/distributed-shell
>            Reporter: Akira AJISAKA
>            Assignee: Binglin Chang
>         Attachments: YARN-1450.v1.patch, 
> org.apache.hadoop.yarn.applications.unmanagedamlauncher.TestUnmanagedAMLauncher-output.txt,
>  
> org.apache.hadoop.yarn.applications.unmanagedamlauncher.TestUnmanagedAMLauncher.txt
>
>
> TestUnmanagedAMLauncher fails on trunk. The console output is
> {code}
> Running 
> org.apache.hadoop.yarn.applications.unmanagedamlauncher.TestUnmanagedAMLauncher
> Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 35.937 sec 
> <<< FAILURE! - in 
> org.apache.hadoop.yarn.applications.unmanagedamlauncher.TestUnmanagedAMLauncher
> testDSShell(org.apache.hadoop.yarn.applications.unmanagedamlauncher.TestUnmanagedAMLauncher)
>   Time elapsed: 14.558 sec  <<< ERROR!
> java.lang.RuntimeException: Failed to receive final expected state in 
> ApplicationReport, CurrentState=ACCEPTED, 
> ExpectedStates=FINISHED,FAILED,KILLED
>       at 
> org.apache.hadoop.yarn.applications.unmanagedamlauncher.UnmanagedAMLauncher.monitorApplication(UnmanagedAMLauncher.java:447)
>       at 
> org.apache.hadoop.yarn.applications.unmanagedamlauncher.UnmanagedAMLauncher.run(UnmanagedAMLauncher.java:352)
>       at 
> org.apache.hadoop.yarn.applications.unmanagedamlauncher.TestUnmanagedAMLauncher.testDSShell(TestUnmanagedAMLauncher.java:145)
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to