[ 
https://issues.apache.org/jira/browse/YARN-10801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359366#comment-17359366
 ] 

Qi Zhu edited comment on YARN-10801 at 6/8/21, 1:42 PM:
--------------------------------------------------------

Thanks [~gandras] for patch LGTM now.

I have a question about the code, if we should also make the 
MaximumApplicationMasterResourcePerQueuePercent to 100% since the user limit 
already unlimted, if we should also make this unlimited?

Other value just 0.5 0.6 0.7, we can't define an accurate value, what do you 
think about this?
cc [~bteke] [~gandras] 
{code:java}
if (isDynamicQueue()) {
  // set to -1, to disable it
  configuration.setUserLimitFactor(getQueuePath(), -1);
  // Set Max AM percentage to a higher value
  configuration.setMaximumApplicationMasterResourcePerQueuePercent(
      getQueuePath(), 0.5f);
}
{code}
Thanks.


was (Author: zhuqi):
Thanks [~gandras] for patch LGTM now.


I have a question about the code, if we should also make the 
MaximumApplicationMasterResourcePerQueuePercent to 100% since the user limit 
already unlimted, if we should also make this unlimited?
{code:java}
if (isDynamicQueue()) {
  // set to -1, to disable it
  configuration.setUserLimitFactor(getQueuePath(), -1);
  // Set Max AM percentage to a higher value
  configuration.setMaximumApplicationMasterResourcePerQueuePercent(
      getQueuePath(), 0.5f);
}
{code}
Thanks.

> Fix Auto Queue template to properly set all configuration properties
> --------------------------------------------------------------------
>
>                 Key: YARN-10801
>                 URL: https://issues.apache.org/jira/browse/YARN-10801
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Andras Gyori
>            Assignee: Andras Gyori
>            Priority: Major
>         Attachments: YARN-10801.001.patch, YARN-10801.002.patch, 
> YARN-10801.003.patch
>
>
> Currently Auto Queue templates set configuration properties only on 
> Configuration object passed in the constructor. Due to the fact, that a lot 
> of configuration values are ready from the Configuration object in csContext, 
> template properties are not set in every cases. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to