[
https://issues.apache.org/jira/browse/YARN-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363192#comment-17363192
]
Szilard Nemeth commented on YARN-10802:
---------------------------------------
Hi [~bteke],
Thanks for working on this.
Some comments for the latest patch:
1. Checking the description: Capacity Scheduler's minimum-user-limit-percent
only accepts integers, which means at most 100 users can use a single fairly.
*Using decimal values could solve this problem.*
Didn't you want to add "using fractional values could solve this problem"?
Also, the name of the testcase
org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue#testDecimalUserLimits
is saying decimal user limits, but you are setting 50.1% which is a fractional.
2. Nit: In
org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue#testDecimalUserLimits
You may replace 0*GB with 0 in assertions like:
{code}
assertEquals(0*GB, app1.getCurrentConsumption().getMemorySize());
{code}
Other than these, the patch looks okay.
> Change Capacity Scheduler minimum-user-limit-percent to accept decimal values
> -----------------------------------------------------------------------------
>
> Key: YARN-10802
> URL: https://issues.apache.org/jira/browse/YARN-10802
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: capacity scheduler
> Reporter: Benjamin Teke
> Assignee: Benjamin Teke
> Priority: Major
> Attachments: YARN-10802.001.patch, YARN-10802.002.patch,
> YARN-10802.003.patch, YARN-10802.004.patch
>
>
> Capacity Scheduler's minimum-user-limit-percent only accepts integers, which
> means at most 100 users can use a single fairly. Using decimal values could
> solve this problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
