[
https://issues.apache.org/jira/browse/YARN-10767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363205#comment-17363205
]
Jim Brennan commented on YARN-10767:
------------------------------------
Thanks for the update [~dmmkr]! I can see that you changed
{noformat}
public static String findActiveRMHAId(YarnConfiguration conf) {
YarnConfiguration yarnConf = new YarnConfiguration(conf);
{noformat}
to
{noformat}
public static String findActiveRMHAId(YarnConfiguration yarnConf) {
{noformat}
Effectively moving the construction of the temporary YarnConfiguration to the
caller.
I see in the other place where this method is called, it was already doing
that.
So in that sense this make sense.
I am wondering about the change in behavior for findActiveRMHAId() though.
Previously, it did not change the conf that was passed in - it made changes in
a local copy. Now, it will modify the passed in conf whether it succeeds or
fails, by setting RM_HA_ID.
That is why I suggested changing it to this:
{noformat}
public static String findActiveRMHAId(Configuration conf) {
YarnConfiguration yarnConf = new YarnConfiguration(conf);
{noformat}
Then you can just use the conf you were passed in.
This does not make any functional difference with the current callers, but it
could matter to future callers, if they assume findActiveRMHAId won't modify
the passed in conf.
> Yarn Logs Command retrying on Standby RM for 30 times
> -----------------------------------------------------
>
> Key: YARN-10767
> URL: https://issues.apache.org/jira/browse/YARN-10767
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: D M Murali Krishna Reddy
> Assignee: D M Murali Krishna Reddy
> Priority: Major
> Attachments: YARN-10767.001.patch, YARN-10767.002.patch,
> YARN-10767.003.patch
>
>
> When ResourceManager HA is enabled and the first RM is unavailable, on
> executing "bin/yarn logs -applicationId <appID> -am 1", we get
> ConnectionException for connecting to the first RM, the ConnectionException
> Occurs for 30 times before it tries to connect to the second RM.
>
> This can be optimized by trying to fetch the logs from the Active RM.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
