[
https://issues.apache.org/jira/browse/YARN-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379091#comment-17379091
]
Rudolf Reti commented on YARN-10580:
------------------------------------
[~akumar] Are you looking into this one, or can we nick it?
> Fix some issues in TestRMWebServicesCapacitySchedDynamicConfig
> --------------------------------------------------------------
>
> Key: YARN-10580
> URL: https://issues.apache.org/jira/browse/YARN-10580
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Ankit Kumar
> Priority: Minor
> Labels: newbie, newbie++
>
> YARN-10512 introduced some changes that could be fixed, [~pbacsko]
> highlighted those issues with this comment.
> Pasting the contents of the comment as a reference
> #1 In TestRMWebServicesCapacitySchedDynamicConfig:
> {noformat}
> config.set(YarnConfiguration.SCHEDULER_CONFIGURATION_STORE_CLASS,
> YarnConfiguration.MEMORY_CONFIGURATION_STORE);
> {noformat}
> This call is repeated multiple times, this could be set somewhere else.
>
> #2 In TestRMWebServicesCapacitySchedDynamicConfig:
> {noformat}
> validateSchedulerInfo(json, "weight", "root.default", "root.test1",
> "root.test2");
> {noformat}
> "root.default", "root.test1" and "root.test2" are the same in all cases, you
> might want to drop them
>
> #3 In TestRMWebServicesCapacitySchedDynamicConfig
> {noformat}
> @Before
> @Override
> public void setUp() throws Exception {
> super.setUp();
> }
> {noformat}
> This method does nothing, can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
