[
https://issues.apache.org/jira/browse/YARN-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835139#comment-13835139
]
Wangda Tan commented on YARN-1447:
----------------------------------
Thanks your review,
I agree with your idea, the additional "Context" not bring any more
information, and flatten such objects are easier for us to add more
information.
And I think for AM->NM increase, we don't need ContainerResourceIncrease, just
a ContainerToken will be enough. Like what community did in
StartContainerRequest, the ContainerId and Resource are already included in
ContainerToken. Agree?
I'll change code cause warnings like findbugs and license and upload a new
patch later. And please let me know if you've any other ideas :)
> Common PB types define for container resource change
> ----------------------------------------------------
>
> Key: YARN-1447
> URL: https://issues.apache.org/jira/browse/YARN-1447
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api
> Affects Versions: 2.2.0
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: yarn-1447.1.patch
>
>
> As described in YARN-1197, we need add some common PB types for container
> resource change, like ResourceChangeContext, etc. These types will be both
> used by RM/NM protocols
--
This message was sent by Atlassian JIRA
(v6.1#6144)
