Szilard Nemeth created YARN-10877:
-------------------------------------
Summary: SLSSchedulerCommons: Consider using application map from
AbstractYarnScheduler and make event handling more consistent
Key: YARN-10877
URL: https://issues.apache.org/jira/browse/YARN-10877
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Szilard Nemeth
Assignee: Szilard Nemeth
This is a follow-up of YARN-10552.
The improvements and things to check are coming from [this
comment|https://issues.apache.org/jira/browse/YARN-10552?focusedCommentId=17277991&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17277991].
{quote}
appQueueMap was not present in SLSFairScheduler before (it was in
SLSCapacityScheduler) however from
https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/SLSFairScheduler.java#L163,
it seems that the super class of the schedulers -
https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java#L159
has this already. As such, do we really need to define a new map as a common
map at all in SLSSchedulerCommons or can we somehow reuse the super class's
map? It might need some code updates though.
In regards to the above point, considering SLSFairScheduler did not previously
have any of the following code in handle() method:
{quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
