[
https://issues.apache.org/jira/browse/YARN-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393158#comment-17393158
]
Gergely Pollák commented on YARN-10355:
---------------------------------------
LGTM+1 Merged to trunk
> Refactor NM ContainerLaunch.java#orderEnvByDependencies
> -------------------------------------------------------
>
> Key: YARN-10355
> URL: https://issues.apache.org/jira/browse/YARN-10355
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
> Reporter: Benjamin Teke
> Assignee: Tamas Domok
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> The
> {{org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch#orderEnvByDependencies}}
> and it's helper method \{{getEnvDependencies }}(together with the overrides)
> is hard to read. Some improvements could be made:
> * use Pattern matching in the overrides of getEnvDependencies instead of
> iterating through the environmental variable strings char by char
> * the unit tests contains a lot of repeated code and generally the test
> methods are long - they could be separated into different setup/helper and
> assertion methods
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
