[
https://issues.apache.org/jira/browse/YARN-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401134#comment-17401134
]
Benjamin Teke commented on YARN-10049:
--------------------------------------
[[email protected]] thanks for the patch. I'm guessing the test issue is
unrelated however there are some checkstyle issues, can you please fix them?
And a nit: assertEquals's first parameter is actually a message for an
erroneous assertion. Can you please update the messages to make them reflect on
the actual error? I.e instead of "Comparator output" -> "r1 is not null and r2
is not null, comparator output should be xyz."
Thanks!
> FIFOOrderingPolicy Improvements
> -------------------------------
>
> Key: YARN-10049
> URL: https://issues.apache.org/jira/browse/YARN-10049
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Manikandan R
> Assignee: Manikandan R
> Priority: Major
> Attachments: YARN-10049.001.patch, YARN-10049.002.patch,
> YARN-10049.003.patch
>
>
> FIFOPolicy of FS does the following comparisons in addition to app priority
> comparison:
> 1. Using Start time
> 2. Using Name
> Scope of this jira is to achieve the same comparisons in FIFOOrderingPolicy
> of CS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
