[
https://issues.apache.org/jira/browse/YARN-10909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412303#comment-17412303
]
Tao Yang commented on YARN-10909:
---------------------------------
Hi, [~jackwangcs]. VisibleForTesting annotation can be used for the methods be
called only in Test scope.
For the PR, I can see AbstractCSQueue#hasChildQueues and
AbstractCSQueue#getLastSubmittedTimestamp are called in both Product and Test
scopes, VisibleForTesting annotation is not fit for them, please take a look.
> AbstractCSQueue: Check for methods added for test code but not annotated with
> VisibleForTesting
> -----------------------------------------------------------------------------------------------
>
> Key: YARN-10909
> URL: https://issues.apache.org/jira/browse/YARN-10909
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Szilard Nemeth
> Assignee: jackwangcs
> Priority: Minor
> Labels: newbie, pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> For example, AbstractCSQueue#setMaxCapacity(float) is only used for testing,
> but not annotated. There can be other methods in this class like this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
