[ 
https://issues.apache.org/jira/browse/YARN-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416721#comment-17416721
 ] 

Adam Antal commented on YARN-10950:
-----------------------------------

Uploaded my patch, if you have some time could you take a look on it [~snemeth]?

> Code cleanup in QueueCapacities
> -------------------------------
>
>                 Key: YARN-10950
>                 URL: https://issues.apache.org/jira/browse/YARN-10950
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Szilard Nemeth
>            Assignee: Adam Antal
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> - Make fields final: capacitiesMap, readLock, writeLock
> - Remove explicit type arguments, e.g. new HashMap<String, Capacities>();
> - Remove abbrevations and avoid string concatenation in 
> QueueCapacities.Capacities#toString
> - Remove unnecessary comments, e.g. "/* Used Capacity Getter and Setter */" & 
> "/* Absolute Used Capacity Getter and Setter */"
> - And probably many more..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to