[ 
https://issues.apache.org/jira/browse/YARN-9818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427309#comment-17427309
 ] 

Eric Badger commented on YARN-9818:
-----------------------------------

This is from a few years ago so I don't quite remember the details, but from 
what I remember, the test was passing back then. The problem was that the test 
wasn't testing what it said it was. This patch was to fix the test so that it 
would accurately test what it was looking to test. But the patch was never 
reviewed/committed

> test_docker_util.cc:test_add_mounts doesn't correctly test for parent dir of 
> container-executor.cfg
> ---------------------------------------------------------------------------------------------------
>
>                 Key: YARN-9818
>                 URL: https://issues.apache.org/jira/browse/YARN-9818
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>            Priority: Major
>         Attachments: YARN-9818.001.patch
>
>
> The code attempts to mount a directory that is a parent of 
> container-executor.cfg. However, the docker.allowed.[ro,rw]-mounts settings 
> in the container-executor.cfg don't allow that directory. So the test isn't 
> ever getting to the code where we disallow the mount because it is a parent 
> of container-executor.cfg. The test is disallowing it because the mount isn't 
> in the allowed mounts list. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to