[
https://issues.apache.org/jira/browse/YARN-11044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Teke updated YARN-11044:
---------------------------------
Description:
TestApplicationLimits.testLimitsComputation() has the following two asserts:
{code:java}
// should default to global setting if per queue setting not set
assertEquals((long)CapacitySchedulerConfiguration.DEFAULT_MAXIMUM_APPLICATIONMASTERS_RESOURCE_PERCENT,
(long)csConf.getMaximumApplicationMasterResourcePerQueuePercent(
queue.getQueuePath()));
{code}
and
{code:java}
assertEquals((long) 0.5,
(long) csConf.getMaximumApplicationMasterResourcePerQueuePercent(
queue.getQueuePath()));
{code}
In the current form neither of them make too much sense because
getMaximumApplicationMasterResourcePerQueuePercent returns a float (between 0
and 1.0), so the only way this will fail is when the configuration is below 0
or above 1, but we're not testing invalid configurations here. This should be
corrected.
was:
TestApplicationLimits.testLimitsComputation() has the following two asserts:
{code:java}
// should default to global setting if per queue setting not set
assertEquals((long)CapacitySchedulerConfiguration.DEFAULT_MAXIMUM_APPLICATIONMASTERS_RESOURCE_PERCENT,
(long)csConf.getMaximumApplicationMasterResourcePerQueuePercent(
queue.getQueuePath()));
{code}
and
{code:java}
assertEquals((long) 0.5,
(long) csConf.getMaximumApplicationMasterResourcePerQueuePercent(
queue.getQueuePath()));
{code}
In the current form neither of them make too much sense because
getMaximumApplicationMasterResourcePerQueuePercent returns a float (between 0
and 1.0), so the only way this will fail, if the configuration is below 0 or
above 1, but we're not testing that here. This should be corrected.
> TestApplicationLimits.testLimitsComputation() has some uneffective asserts
> --------------------------------------------------------------------------
>
> Key: YARN-11044
> URL: https://issues.apache.org/jira/browse/YARN-11044
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Benjamin Teke
> Priority: Major
>
> TestApplicationLimits.testLimitsComputation() has the following two asserts:
> {code:java}
> // should default to global setting if per queue setting not set
> assertEquals((long)CapacitySchedulerConfiguration.DEFAULT_MAXIMUM_APPLICATIONMASTERS_RESOURCE_PERCENT,
> (long)csConf.getMaximumApplicationMasterResourcePerQueuePercent(
> queue.getQueuePath()));
> {code}
> and
> {code:java}
> assertEquals((long) 0.5,
> (long) csConf.getMaximumApplicationMasterResourcePerQueuePercent(
> queue.getQueuePath()));
> {code}
> In the current form neither of them make too much sense because
> getMaximumApplicationMasterResourcePerQueuePercent returns a float (between 0
> and 1.0), so the only way this will fail is when the configuration is below 0
> or above 1, but we're not testing invalid configurations here. This should be
> corrected.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
