[
https://issues.apache.org/jira/browse/YARN-10943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468495#comment-17468495
]
Andras Gyori commented on YARN-10943:
-------------------------------------
[~snemeth] Not sure if its worth the effort implementing this. What is the
advantage of this refactor? As Java8 does not have destructuring and an easy
way to handle POJOs, I would refrain from this change.
> AbstractCSQueue: Create separate class for encapsulating Min / Max Resource
> ---------------------------------------------------------------------------
>
> Key: YARN-10943
> URL: https://issues.apache.org/jira/browse/YARN-10943
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
>
> There are certain methods where min and max Resources are used in tandem.
> Some examples of these kind of methods:
> - getMinimumAbsoluteResource / getMaximumAbsoluteResource
> - *updateConfigurableResourceLimits:*
> - It invokes setConfiguredMinResource / setConfiguredMaxResource on
> QueueResourceQuotas. That object could define a simple method that receives
> the MinMaxResource alone.
> - Validator methods are also receiving min/max resources as separate
> parameters, which could be tied together.
> - updateEffectiveResources: It performs operations with effective min/max
> resources.
> Alternatively, 2 classes could be created:
> - One for EffectiveMinMaxResource
> - And another for AbsoluteMinMaxResource
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
