[ 
https://issues.apache.org/jira/browse/YARN-10894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496596#comment-17496596
 ] 

Szilard Nemeth commented on YARN-10894:
---------------------------------------

Thanks [~tdomok]

> Follow up YARN-10237: fix the new test case in TestRMWebServicesCapacitySched
> -----------------------------------------------------------------------------
>
>                 Key: YARN-10894
>                 URL: https://issues.apache.org/jira/browse/YARN-10894
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Tamas Domok
>            Assignee: Tamas Domok
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> The new test case (added with 
> [YARN-10237|https://issues.apache.org/jira/secure/attachment/13001074/YARN-10237-003.patch])
>  in *TestRMWebServicesCapacitySched* is not testing anything:
> A new queue "*C*" was created:
> {code:java}
> final String C = CapacitySchedulerConfiguration.ROOT + ".c";    
> config.setCapacity(C, "[memory=1024]");
> {code}
> but it was not added to the top level queues:
> {code:java}
> // Define top-level queues
> config.setQueues(CapacitySchedulerConfiguration.ROOT,
>     new String[] {"a", "b"});{code}
> So it does not test anything.
> The asserts later should check the queue name like this:
> {code:java}
> - if (q.equals("c")) { 
> + if (q.equals("root.c")) { {code}
> Unfortunately some other asserts fail, so either the test is faulty or there 
> is some issue with the code.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to