[
https://issues.apache.org/jira/browse/YARN-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838293#comment-13838293
]
Sandy Ryza commented on YARN-1181:
----------------------------------
Just a few stylistic comments.
{code}
+ if (resourceManagers.length == 1)
+ return 0;
{code}
Should have curly braces.
{code}
+ } catch (IOException e) {
+ throw new YarnRuntimeException("Couldn't read the status of " +
+ "a ResourceManger in the HA ensemble.");
+ }
{code}
We should include the original exception as the cause?
{code}
+ super.serviceInit(conf instanceof YarnConfiguration
+ ? conf
+ : new YarnConfiguration(conf));
{code}
Unless this was intentional, can move the last two lines onto the same line.
{code}
+ @InterfaceAudience.Private
+ int getActiveRMIndex() {
{code}
Can we add short doc to this method that explains what it's doing / that it can
take some time?
{code}
+ assertFalse("RM never turned active", -1 == cluster.getActiveRMIndex());
{code}
Should use assertNotEqual
> Augment MiniYARNCluster to support HA mode
> ------------------------------------------
>
> Key: YARN-1181
> URL: https://issues.apache.org/jira/browse/YARN-1181
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: yarn-1181-1.patch, yarn-1181-2.patch, yarn-1181-3.patch,
> yarn-1181-4.patch
>
>
> MiniYARNHACluster, along the lines of MiniYARNCluster, is needed for
> end-to-end HA tests.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
