[
https://issues.apache.org/jira/browse/YARN-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511762#comment-17511762
]
András Győri commented on YARN-10552:
-------------------------------------
Thanks [~snemeth] for the patch. I had one comment on this, otherwise LGTM and
will commit it after the fixes:
* SLSSchedulerCommons#L57: Raw used of AbstractYarnScheduler. The easiest way
to avoid it would be to use ?, ? parameters at least (or make the commons
generic as well, but this is not needed I think, because we are not interested
about the type parameters
> Eliminate code duplication in SLSCapacityScheduler and SLSFairScheduler
> -----------------------------------------------------------------------
>
> Key: YARN-10552
> URL: https://issues.apache.org/jira/browse/YARN-10552
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-10552.001.patch, YARN-10552.002.patch,
> YARN-10552.003.patch, YARN-10552.004.patch
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
