[
https://issues.apache.org/jira/browse/YARN-11143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ding Ding updated YARN-11143:
-----------------------------
Description:
Hello,
While viewing the MAPREDUCE-4262, I found that the logging statements might
give inaccurate messages.
I also found that the in the line *119* of the file
{*}[{*}{*}LeveldbTimelineStateStore{*}{*}|https://github.com/apache/hadoop/blob/dbd255f4a96474b31af2bd45c952ac7151a265b9/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/recovery/LeveldbTimelineStateStore.java#L119]{*},
the log messages says "{_}Creating a new database at th path: "{_}. Howver,
the database creation should already completed in previous code ({*}line 117
and 118{*}).
Would it be better if we change the verb "Creating" to "Created" to indicate
the action is completed? Or can we move the logging statement to the line
before {*}117{*}? Since when there was an exception in {*}line 117 and 118{*},
the logging message would not be printed, which may be not good for debugging.
was:
Hello,
While viewing the
[MAPREDUCE-4262|https://issues.apache.org/jira/browse/MAPREDUCE-4262], I found
that the logging statements might give inaccurate messages.
I also found that the in the line *119* of the file
{*}LeveldbTimelineStateStore{*}, the log messages says "{_}Creating a new
database at th path: "{_}. Howver, the database creation should already
completed in previous code ({*}line 117 and 118{*}).
Would it be better if we change the verb "Creating" to "Created" to indicate
the action is completed? Or can we move the logging statement to the line
before {*}117{*}? Since when there was an exception in {*}line 117 and 118{*},
the logging message would not be printed, which may be not good for debugging.
> LeveldbTimelineStateStore gives inaccurate log message saying "Creating a new
> database at th path ... " after already created the database
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-11143
> URL: https://issues.apache.org/jira/browse/YARN-11143
> Project: Hadoop YARN
> Issue Type: Bug
> Components: yarn
> Reporter: Ding Ding
> Priority: Trivial
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hello,
> While viewing the MAPREDUCE-4262, I found that the logging statements might
> give inaccurate messages.
> I also found that the in the line *119* of the file
> {*}[{*}{*}LeveldbTimelineStateStore{*}{*}|https://github.com/apache/hadoop/blob/dbd255f4a96474b31af2bd45c952ac7151a265b9/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/recovery/LeveldbTimelineStateStore.java#L119]{*},
> the log messages says "{_}Creating a new database at th path: "{_}. Howver,
> the database creation should already completed in previous code ({*}line 117
> and 118{*}).
> Would it be better if we change the verb "Creating" to "Created" to indicate
> the action is completed? Or can we move the logging statement to the line
> before {*}117{*}? Since when there was an exception in {*}line 117 and
> 118{*}, the logging message would not be printed, which may be not good for
> debugging.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
