[ 
https://issues.apache.org/jira/browse/YARN-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839097#comment-13839097
 ] 

Xuan Gong commented on YARN-1435:
---------------------------------

bq. 2. Maybe it's good to change the hardcoded variables bellow to static? And 
some others in Client.java?

Those variables will be used in App.java or Client.java only. I think it should 
be fine to define as final

bq. You may want to comment why in windows, the output can not be assert 
line-by-line.

Added

bq. Can we use copyFromLocal as well for Windows?

Tested and changed

> Distributed Shell should not run other commands except "sh", and run the 
> custom script at the same time.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1435
>                 URL: https://issues.apache.org/jira/browse/YARN-1435
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications/distributed-shell
>    Affects Versions: 2.3.0
>            Reporter: Tassapol Athiapinya
>            Assignee: Xuan Gong
>         Attachments: YARN-1435.1.patch, YARN-1435.1.patch, YARN-1435.2.patch, 
> YARN-1435.3.patch
>
>
> Currently, if we want to run custom script at DS. We can do it like this :
> --shell_command sh --shell_script custom_script.sh
> But it may be better to separate running shell_command and shell_script



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to