[ https://issues.apache.org/jira/browse/YARN-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839348#comment-13839348 ]
Jian He commented on YARN-1307: ------------------------------- Sorry for the late response, patch looks good overall. one comment: Secret key is stored under rmDelegationKeyPath but, removed from a different path, can you also update the test case to cover this scenario ? thanks. {code} @Override protected synchronized void removeRMDTMasterKeyState( DelegationKey delegationKey) throws Exception { String nodeRemovePath = getNodePath(rmDTSecretManagerRoot, DELEGATION_KEY_PREFIX + delegationKey.getKeyId()); {code} > Rethink znode structure for RM HA > --------------------------------- > > Key: YARN-1307 > URL: https://issues.apache.org/jira/browse/YARN-1307 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Tsuyoshi OZAWA > Assignee: Tsuyoshi OZAWA > Attachments: YARN-1307.1.patch, YARN-1307.10.patch, > YARN-1307.2.patch, YARN-1307.3.patch, YARN-1307.4-2.patch, > YARN-1307.4-3.patch, YARN-1307.4.patch, YARN-1307.5.patch, YARN-1307.6.patch, > YARN-1307.7.patch, YARN-1307.8.patch, YARN-1307.9.patch, YARN-1307.9.patch > > > Rethink for znode structure for RM HA is proposed in some JIRAs(YARN-659, > YARN-1222). The motivation of this JIRA is quoted from Bikas' comment in > YARN-1222: > {quote} > We should move to creating a node hierarchy for apps such that all znodes for > an app are stored under an app znode instead of the app root znode. This will > help in removeApplication and also in scaling better on ZK. The earlier code > was written this way to ensure create/delete happens under a root znode for > fencing. But given that we have moved to multi-operations globally, this isnt > required anymore. > {quote} -- This message was sent by Atlassian JIRA (v6.1#6144)