[
https://issues.apache.org/jira/browse/YARN-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839644#comment-13839644
]
Alejandro Abdelnur commented on YARN-1403:
------------------------------------------
* FairScheduler.java
** Given that the AllocationFileLoaderService is a service, shouldn'd its
lifecycle start/stop be managed as other services? here reinitialize() is doing
start and there is no stop. this is a bit off, no?
* FairSchedulerQueueInfo.java
** in case of reload, the maxApps var here never gets updated, shouldn't the
getMaxApplications() method be as follows so the max is properly refreshed?
{code}
public int getMaxApplications() {
return scheduler.getAllocationConfiguration().getQueueMaxApps(queueName);
}
{code}
> Separate out configuration loading from QueueManager in the Fair Scheduler
> --------------------------------------------------------------------------
>
> Key: YARN-1403
> URL: https://issues.apache.org/jira/browse/YARN-1403
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Sandy Ryza
> Assignee: Sandy Ryza
> Attachments: YARN-1403-1.patch, YARN-1403-2.patch, YARN-1403-3.patch,
> YARN-1403-4.patch, YARN-1403-5.patch, YARN-1403.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)