[
https://issues.apache.org/jira/browse/YARN-11180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573044#comment-17573044
]
fanshilun commented on YARN-11180:
----------------------------------
[~elgoiri] Thanks for your help reviewing the code!
> Refactor some code of getNewApplication, submitApplication,
> forceKillApplication, getApplicationReport
> ------------------------------------------------------------------------------------------------------
>
> Key: YARN-11180
> URL: https://issues.apache.org/jira/browse/YARN-11180
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> *1) FederationClientInterceptor#getNewApplication*
> 1.Increase request is empty check
> 2.Use RouterServerUtil.logAndThrowException instead of throw YarnRuntime
> Exception.
> *2)
> FederationClientInterceptor#submitApplication/forceKillApplication/getApplicationReport/getApplications*
> 1.Use RouterServerUtil.logAndThrowException instead of throw YarnRuntime
> Exception.
> 2.Use string.format instead of +
> 3.Fix Code Style.
> *3) FederationClientInterceptor#getClusterMetrics*
> 1.Increase request is empty check
> *4)
> FederationClientInterceptor#getClusterNodes/getQueueUserAcls/listReservations/getNodeToLabels/getLabelsToNodes/getClusterNodeLabels*
> 1.Use RouterServerUtil.logAndThrowException instead of throw YarnRuntime
> Exception.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
