[
https://issues.apache.org/jira/browse/YARN-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840025#comment-13840025
]
Karthik Kambatla commented on YARN-546:
---------------------------------------
Thanks Sandy. Couple of nits:
# {code}
+ /** Whether to enable the Fair Scheduler event log */
+ protected static final String EVENT_LOG_ENABLED = CONF_PREFIX +
"event-log-enabled";
+ protected static final boolean DEFAULT_EVENT_LOG_ENABLED = false;
{code}
Both protected? At least the config name should be public, no?
# {code}
+ public boolean getEventLogEnabled() {
+ return getBoolean(EVENT_LOG_ENABLED, DEFAULT_EVENT_LOG_ENABLED);
+ }
{code}
May be rename it to {{isEventLogEnabled()}} to reflect boolean return? Also, in
many other cases (RM etc.), we have these methods or config-accesses in the
class that uses them and not in *Configuration. Any reason to not follow the
same?
> mapred.fairscheduler.eventlog.enabled removed from Hadoop 2.0
> -------------------------------------------------------------
>
> Key: YARN-546
> URL: https://issues.apache.org/jira/browse/YARN-546
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
> Affects Versions: 2.0.3-alpha
> Reporter: Lohit Vijayarenu
> Assignee: Sandy Ryza
> Attachments: YARN-546.1.patch, YARN-546.patch
>
>
> Hadoop 1.0 supported an option to turn on/off FairScheduler event logging
> using mapred.fairscheduler.eventlog.enabled. In Hadoop 2.0, it looks like
> this option has been removed (or not ported?) which causes event logging to
> be enabled by default and there is no way to turn it off.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
