[
https://issues.apache.org/jira/browse/YARN-11153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579505#comment-17579505
]
ASF GitHub Bot commented on YARN-11153:
---------------------------------------
zhengchenyu commented on code in PR #4314:
URL: https://github.com/apache/hadoop/pull/4314#discussion_r945404189
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java:
##########
@@ -134,16 +132,19 @@ public WebAppProxyServlet() {
this.trackingUriPlugins =
conf.getInstances(YarnConfiguration.YARN_TRACKING_URL_GENERATOR,
TrackingUriPlugin.class);
- this.rmAppPageUrlBase =
- StringHelper.pjoin(WebAppUtils.getResolvedRMWebAppURLWithScheme(conf),
- "cluster", "app");
this.failurePageUrlBase =
StringHelper.pjoin(WebAppUtils.getResolvedRMWebAppURLWithScheme(conf),
"cluster", "failure");
- this.ahsAppPageUrlBase =
- StringHelper.pjoin(WebAppUtils.getHttpSchemePrefix(conf)
- + WebAppUtils.getAHSWebAppURLWithoutScheme(conf),
- "applicationhistory", "app");
+ }
+
+ private String getRmAppPageUrlBase(ApplicationId id) throws YarnException,
IOException {
+ return ((AppReportFetcher)
getServletContext().getAttribute(WebAppProxy.FETCHER_ATTRIBUTE))
Review Comment:
This code should show like this. If refactor is only for clean code. I think
it is not very clean.
```
ServletContext context = getServletContext();
AppReportFetcher report =
((AppReportFetcher)
context.getAttribute(WebAppProxy.FETCHER_ATTRIBUTE));
return report.getRmAppPageUrlBase(id);
```
> Make proxy server support YARN federation.
> ------------------------------------------
>
> Key: YARN-11153
> URL: https://issues.apache.org/jira/browse/YARN-11153
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Affects Versions: 3.2.1
> Reporter: zhengchenyu
> Assignee: zhengchenyu
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> Detail message see: https://issues.apache.org/jira/browse/YARN-10775 and
> YARN-10775-design-doc.001.pdf
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
