[
https://issues.apache.org/jira/browse/YARN-11253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
fanshilun updated YARN-11253:
-----------------------------
Description:
When reading the code, I found the case of hard coding, I think the parameters
should be abstracted into the configuration.
org.apache.hadoop.yarn.server.resourcemanager.RMSecretManagerService#
createRMDelegationTokenSecretManager
{code:java}
protected RMDelegationTokenSecretManager createRMDelegationTokenSecretManager(
Configuration conf, RMContext rmContext) { long secretKeyInterval =
conf.getLong(YarnConfiguration.RM_DELEGATION_KEY_UPDATE_INTERVAL_KEY,
YarnConfiguration.RM_DELEGATION_KEY_UPDATE_INTERVAL_DEFAULT); long
tokenMaxLifetime =
conf.getLong(YarnConfiguration.RM_DELEGATION_TOKEN_MAX_LIFETIME_KEY,
YarnConfiguration.RM_DELEGATION_TOKEN_MAX_LIFETIME_DEFAULT); long
tokenRenewInterval =
conf.getLong(YarnConfiguration.RM_DELEGATION_TOKEN_RENEW_INTERVAL_KEY,
YarnConfiguration.RM_DELEGATION_TOKEN_RENEW_INTERVAL_DEFAULT);
return new RMDelegationTokenSecretManager(secretKeyInterval,
tokenMaxLifetime, tokenRenewInterval, 3600000, rmContext); } {code}
was:
When reading the code, I found the case of hard coding, I think the parameters
should be abstracted into the configuration.
org.apache.hadoop.yarn.server.resourcemanager.RMSecretManagerService#
createRMDelegationTokenSecretManager
> Add Configuration to delegationToken RemoverScanInterval
> --------------------------------------------------------
>
> Key: YARN-11253
> URL: https://issues.apache.org/jira/browse/YARN-11253
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Affects Versions: 3.4.0, 3.3.4
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
>
> When reading the code, I found the case of hard coding, I think the
> parameters should be abstracted into the configuration.
> org.apache.hadoop.yarn.server.resourcemanager.RMSecretManagerService#
> createRMDelegationTokenSecretManager
> {code:java}
> protected RMDelegationTokenSecretManager
> createRMDelegationTokenSecretManager( Configuration conf, RMContext
> rmContext) { long secretKeyInterval =
> conf.getLong(YarnConfiguration.RM_DELEGATION_KEY_UPDATE_INTERVAL_KEY,
> YarnConfiguration.RM_DELEGATION_KEY_UPDATE_INTERVAL_DEFAULT); long
> tokenMaxLifetime =
> conf.getLong(YarnConfiguration.RM_DELEGATION_TOKEN_MAX_LIFETIME_KEY,
> YarnConfiguration.RM_DELEGATION_TOKEN_MAX_LIFETIME_DEFAULT); long
> tokenRenewInterval =
> conf.getLong(YarnConfiguration.RM_DELEGATION_TOKEN_RENEW_INTERVAL_KEY,
> YarnConfiguration.RM_DELEGATION_TOKEN_RENEW_INTERVAL_DEFAULT);
> return new RMDelegationTokenSecretManager(secretKeyInterval,
> tokenMaxLifetime, tokenRenewInterval, 3600000, rmContext); } {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
