[
https://issues.apache.org/jira/browse/YARN-11250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580514#comment-17580514
]
ASF GitHub Bot commented on YARN-11250:
---------------------------------------
slfan1989 commented on code in PR #4738:
URL: https://github.com/apache/hadoop/pull/4738#discussion_r947366439
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.java:
##########
@@ -104,29 +107,39 @@
public class ZookeeperFederationStateStore implements FederationStateStore {
private static final Logger LOG =
- LoggerFactory.getLogger(ZookeeperFederationStateStore.class);
+ LoggerFactory.getLogger(ZookeeperFederationStateStore.class);
private final static String ROOT_ZNODE_NAME_MEMBERSHIP = "memberships";
private final static String ROOT_ZNODE_NAME_APPLICATION = "applications";
private final static String ROOT_ZNODE_NAME_POLICY = "policies";
- /** Interface to Zookeeper. */
+ /**
+ * Interface to Zookeeper.
+ */
private ZKCuratorManager zkManager;
- /** Directory to store the state store data. */
+ /**
+ * Directory to store the state store data.
+ */
private String baseZNode;
private String appsZNode;
private String membershipZNode;
private String policiesZNode;
+ private volatile Clock clock = SystemClock.getInstance();
+
+ @VisibleForTesting
+ private ZKFederationStateStoreOpDurations opDurations =
+ ZKFederationStateStoreOpDurations.getInstance();
+
@Override
public void init(Configuration conf) throws YarnException {
LOG.info("Initializing ZooKeeper connection");
baseZNode = conf.get(
- YarnConfiguration.FEDERATION_STATESTORE_ZK_PARENT_PATH,
- YarnConfiguration.DEFAULT_FEDERATION_STATESTORE_ZK_PARENT_PATH);
+ YarnConfiguration.FEDERATION_STATESTORE_ZK_PARENT_PATH,
Review Comment:
I will fix it.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.java:
##########
@@ -203,53 +217,58 @@ public AddApplicationHomeSubClusterResponse
addApplicationHomeSubCluster(
FederationStateStoreUtils.logAndThrowStoreException(LOG, errMsg);
}
SubClusterId newSubClusterId =
- request.getApplicationHomeSubCluster().getHomeSubCluster();
+ request.getApplicationHomeSubCluster().getHomeSubCluster();
Review Comment:
I will fix it.
> Capture the Performance Metrics of ZookeeperFederationStateStore
> ----------------------------------------------------------------
>
> Key: YARN-11250
> URL: https://issues.apache.org/jira/browse/YARN-11250
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: federation
> Affects Versions: 3.4.0, 3.3.4
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
