[ 
https://issues.apache.org/jira/browse/YARN-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581319#comment-17581319
 ] 

ASF GitHub Bot commented on YARN-9708:
--------------------------------------

slfan1989 commented on code in PR #4746:
URL: https://github.com/apache/hadoop/pull/4746#discussion_r949059137


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/utils/TestFederationStateStoreFacade.java:
##########
@@ -312,10 +312,10 @@ public void testUpdateNewToken() throws YarnException, 
IOException {
     facade.updateStoredToken(dtId1, renewDate1);
     token1.put(dtId1, renewDate1);
 
-    MemoryFederationStateStore stateStore =
+    MemoryFederationStateStore federationStateStore =

Review Comment:
   Thank you very much for your help reviewing the code.
   
   checkStyle reported a compilation problem
   
   ```
   ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-
   
common/src/test/java/org/apache/hadoop/yarn/server/federation/utils/TestFederationStateStoreFacade.java:315:
    
   MemoryFederationStateStore stateStore =:32: 'stateStore' hides a field. 
[HiddenField]
   
   ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-
   
common/src/test/java/org/apache/hadoop/yarn/server/federation/utils/TestFederationStateStoreFacade.java:341:
    
   MemoryFederationStateStore stateStore =:32: 'stateStore' hides a field. 
[HiddenField]
   ```
   
   





> Yarn Router Support DelegationToken
> -----------------------------------
>
>                 Key: YARN-9708
>                 URL: https://issues.apache.org/jira/browse/YARN-9708
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: router
>    Affects Versions: 3.1.1
>            Reporter: Xie YiFan
>            Assignee: fanshilun
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: Add_getDelegationToken_and_SecureLogin_in_router.patch
>
>
> 1.we use router as proxy to manage multiple cluster which be independent of 
> each other in order to apply unified client. Thus, we implement our 
> customized AMRMProxyPolicy that doesn't broadcast ResourceRequest to other 
> cluster.
> 2.Our production environment need kerberos. But router doesn't support 
> SecureLogin for now.
> https://issues.apache.org/jira/browse/YARN-6539 desn't work. So we 
> improvement it.
> 3.Some framework like oozie would get Token via yarnclient#getDelegationToken 
> which router doesn't support. Our solution is that adding homeCluster to 
> ApplicationSubmissionContextProto & GetDelegationTokenRequestProto. Job would 
> be submitted with specified clusterid so that router knows which cluster to 
> submit this job. Router would get Token from one RM according to specified 
> clusterid when client call getDelegation meanwhile apply some mechanism to 
> save this token in memory.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to