[
https://issues.apache.org/jira/browse/YARN-11269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17582330#comment-17582330
]
ASF GitHub Bot commented on YARN-11269:
---------------------------------------
ashutoshcipher commented on code in PR #4771:
URL: https://github.com/apache/hadoop/pull/4771#discussion_r950714674
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage/src/test/java/org/apache/hadoop/yarn/server/timeline/TestEntityGroupFSTimelineStore.java:
##########
@@ -173,7 +178,7 @@ public void setup() throws Exception {
}
store = new EntityGroupFSTimelineStore();
- if (currTestName.getMethodName().contains("Plugin")) {
+ if (testInfo.getDisplayName().contains("Plugin")) {
Review Comment:
And output of `currTestName.getMethodName()` gives output as
`testPluginRead()` for `testPluginRead` method
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage/src/test/java/org/apache/hadoop/yarn/server/timeline/TestEntityGroupFSTimelineStore.java:
##########
@@ -173,7 +178,7 @@ public void setup() throws Exception {
}
store = new EntityGroupFSTimelineStore();
- if (currTestName.getMethodName().contains("Plugin")) {
+ if (testInfo.getDisplayName().contains("Plugin")) {
Review Comment:
I checked, But there is no such method `getName()` from
`testInfo.getTestMethod()`.
> Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timeline-pluginstorage
> ----------------------------------------------------------------------
>
> Key: YARN-11269
> URL: https://issues.apache.org/jira/browse/YARN-11269
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: test, yarn
> Affects Versions: 3.3.4
> Reporter: groot
> Assignee: groot
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
