[ https://issues.apache.org/jira/browse/YARN-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhijie Shen updated YARN-1023: ------------------------------ Attachment: YARN-1023.3.patch @Mayank bansal, thanks for the review. I've updated the patch, which improves the tests and fixes some minor bugs. bq. Can you test some other fields other then ID? I added more code to test other fields. However, as I mentioned before, I don't want to test AHSWebServices fully as most of the code will duplicate TestRMWebServicesApps again. After merging into the trunk, we will refactor the web interface code, and the test code will probably be removed. bq. How its teting the application type as we don't have that as part of interface for history? bq. For the clients we have getapplications get the info from RM and I think we should retain that behavior Talked to Mayank offline. RM web services allow the app list API, and the filters, therefore AHS should provide the same, though the current implementation is not efficient enough: going through all the applications and use the filters to check whether the application is desired or not one-by-one (like what RM web services does). In the future, when we have filters for the reader interface, we can push the filtering operations into the store implementation, which knows best about how to improve the filtering performance. On the other side, AHS web interface is now serving the application list, while CLI doesn't. I agree we should keep consistent, but instead of removing the interface of getting application list from web, we should add this feature to CLI (maybe after merging the branch into the trunk). By default, CLI returns application list only in RMContext, while with some specific param/option/flag, we should let users to query application list from AHS as well. There's a related problem, which is not just restricted in AHS: nowadays RM web services allows more filters than CLI when getting an application list > [YARN-321] Webservices REST API's support for Application History > ----------------------------------------------------------------- > > Key: YARN-1023 > URL: https://issues.apache.org/jira/browse/YARN-1023 > Project: Hadoop YARN > Issue Type: Sub-task > Affects Versions: YARN-321 > Reporter: Devaraj K > Assignee: Zhijie Shen > Attachments: YARN-1023-v0.patch, YARN-1023-v1.patch, > YARN-1023.2.patch, YARN-1023.3.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)