[ 
https://issues.apache.org/jira/browse/YARN-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599831#comment-17599831
 ] 

ASF GitHub Bot commented on YARN-7614:
--------------------------------------

slfan1989 commented on code in PR #4843:
URL: https://github.com/apache/hadoop/pull/4843#discussion_r962119145


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/MockDefaultRequestInterceptorREST.java:
##########
@@ -788,4 +819,67 @@ public AppActivitiesInfo getAppActivities(
 
     return appActivitiesInfo;
   }
+
+  @Override
+  public Response listReservation(String queue, String reservationId, long 
startTime, long endTime,
+      boolean includeResourceAllocations, HttpServletRequest hsr) throws 
Exception {
+
+    if (!isRunning) {
+      throw new RuntimeException("RM is stopped");
+    }
+
+    if (!StringUtils.equals(queue, QUEUE_DEDICATED_FULL)) {
+      throw new RuntimeException("The specified queue: " + queue +
+          " is not managed by reservation system." +
+          " Please try again with a valid reservable queue.");
+    }
+
+    ReservationId reservationID = 
ReservationId.parseReservationId(reservationId);
+    ReservationSystem reservationSystem = mockRM.getReservationSystem();
+    reservationSystem.synchronizePlan(QUEUE_DEDICATED_FULL, true);
+
+    // Generate reserved resources
+    ClientRMService clientService = mockRM.getClientRMService();
+    long arrival = Time.now();
+    long duration = 60000;
+    long deadline = (long) (arrival + 1.05 * duration);
+    ReservationSubmissionRequest submissionRequest =
+        
ReservationSystemTestUtil.createSimpleReservationRequest(reservationID, 4,
+        arrival, deadline, duration);

Review Comment:
   I will fix it.





> [RESERVATION] Support ListReservation APIs in Federation Router
> ---------------------------------------------------------------
>
>                 Key: YARN-7614
>                 URL: https://issues.apache.org/jira/browse/YARN-7614
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: federation, reservation system
>            Reporter: Carlo Curino
>            Assignee: fanshilun
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to