[ https://issues.apache.org/jira/browse/YARN-11290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599955#comment-17599955 ]
ASF GitHub Bot commented on YARN-11290: --------------------------------------- hadoop-yetus commented on PR #4846: URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1236140992 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 36s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 1s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. | | +0 :ok: | xmllint | 0m 0s | | xmllint was not available. | | +0 :ok: | buf | 0m 0s | | buf was not available. | | +0 :ok: | buf | 0m 0s | | buf was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 5 new or modified test files. | |||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 15m 40s | | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 25m 32s | | trunk passed | | +1 :green_heart: | compile | 9m 51s | | trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | compile | 8m 40s | | trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | checkstyle | 2m 5s | | trunk passed | | +1 :green_heart: | mvnsite | 8m 7s | | trunk passed | | +1 :green_heart: | javadoc | 5m 52s | | trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | javadoc | 5m 11s | | trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 17m 26s | | trunk passed | | +1 :green_heart: | shadedclient | 20m 36s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 28s | | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 53s | | the patch passed | | +1 :green_heart: | compile | 9m 13s | | the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | cc | 9m 13s | | the patch passed | | +1 :green_heart: | javac | 9m 13s | | the patch passed | | +1 :green_heart: | compile | 8m 38s | | the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | cc | 8m 38s | | the patch passed | | +1 :green_heart: | javac | 8m 38s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | -0 :warning: | checkstyle | 1m 49s | [/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4846/2/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt) | hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 165 unchanged - 0 fixed = 168 total (was 165) | | +1 :green_heart: | mvnsite | 7m 33s | | the patch passed | | +1 :green_heart: | javadoc | 5m 13s | | the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | javadoc | 4m 42s | | the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | -1 :x: | spotbugs | 12m 2s | [/new-spotbugs-hadoop-yarn-project_hadoop-yarn.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4846/2/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn.html) | hadoop-yarn-project/hadoop-yarn generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | -1 :x: | spotbugs | 1m 34s | [/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4846/2/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.html) | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | +1 :green_heart: | shadedclient | 20m 43s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 237m 32s | | hadoop-yarn in the patch passed. | | +1 :green_heart: | unit | 1m 38s | | hadoop-yarn-api in the patch passed. | | +1 :green_heart: | unit | 5m 31s | | hadoop-yarn-common in the patch passed. | | +1 :green_heart: | unit | 3m 30s | | hadoop-yarn-server-common in the patch passed. | | +1 :green_heart: | asflicense | 1m 38s | | The patch does not generate ASF License warnings. | | | | 454m 42s | | | | Reason | Tests | |-------:|:------| | SpotBugs | module:hadoop-yarn-project/hadoop-yarn | | | Redundant nullcheck of filterSubCluster, which is known to be non-null in org.apache.hadoop.yarn.server.federation.store.impl.MemoryFederationStateStore.judgeAdd(SubClusterId, SubClusterId) Redundant null check at MemoryFederationStateStore.java:is known to be non-null in org.apache.hadoop.yarn.server.federation.store.impl.MemoryFederationStateStore.judgeAdd(SubClusterId, SubClusterId) Redundant null check at MemoryFederationStateStore.java:[line 288] | | | Redundant nullcheck of filterSubCluster, which is known to be non-null in org.apache.hadoop.yarn.server.federation.store.impl.ZookeeperFederationStateStore.judgeAdd(SubClusterId, SubClusterId) Redundant null check at ZookeeperFederationStateStore.java:is known to be non-null in org.apache.hadoop.yarn.server.federation.store.impl.ZookeeperFederationStateStore.judgeAdd(SubClusterId, SubClusterId) Redundant null check at ZookeeperFederationStateStore.java:[line 306] | | SpotBugs | module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common | | | Redundant nullcheck of filterSubCluster, which is known to be non-null in org.apache.hadoop.yarn.server.federation.store.impl.MemoryFederationStateStore.judgeAdd(SubClusterId, SubClusterId) Redundant null check at MemoryFederationStateStore.java:is known to be non-null in org.apache.hadoop.yarn.server.federation.store.impl.MemoryFederationStateStore.judgeAdd(SubClusterId, SubClusterId) Redundant null check at MemoryFederationStateStore.java:[line 288] | | | Redundant nullcheck of filterSubCluster, which is known to be non-null in org.apache.hadoop.yarn.server.federation.store.impl.ZookeeperFederationStateStore.judgeAdd(SubClusterId, SubClusterId) Redundant null check at ZookeeperFederationStateStore.java:is known to be non-null in org.apache.hadoop.yarn.server.federation.store.impl.ZookeeperFederationStateStore.judgeAdd(SubClusterId, SubClusterId) Redundant null check at ZookeeperFederationStateStore.java:[line 306] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4846/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4846 | | Optional Tests | dupname asflicense codespell detsecrets compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle xmllint cc buflint bufcompat | | uname | Linux da8b0101bd89 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / a1629b7b74d2f77035dee07e0a9cf4477ebe6d07 | | Default Java | Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4846/2/testReport/ | | Max. process+thread count | 2775 (vs. ulimit of 5500) | | modules | C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4846/2/console | | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster > ----------------------------------------------------------------------------- > > Key: YARN-11290 > URL: https://issues.apache.org/jira/browse/YARN-11290 > Project: Hadoop YARN > Issue Type: Improvement > Components: federation > Affects Versions: 3.4.0 > Reporter: fanshilun > Assignee: fanshilun > Priority: Minor > Labels: pull-request-available > > 1. Currently this interface returns the number of apps in all sub-clusters, > increasing the limit on the number of query apps, limited to 1000 apps. > 2. Allows to query the App based on the specified HomeSubCluster. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org