[
https://issues.apache.org/jira/browse/YARN-11297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601507#comment-17601507
]
ASF GitHub Bot commented on YARN-11297:
---------------------------------------
slfan1989 commented on code in PR #4863:
URL: https://github.com/apache/hadoop/pull/4863#discussion_r965307988
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptor.java:
##########
@@ -1404,10 +1390,12 @@ public void testSubmitReservationMultipleSubmission()
throws Exception {
Assert.assertNotNull(subClusterId1);
Assert.assertTrue(subClusters.contains(subClusterId1));
- // First Retry
+ // First Retry, Repeat the submission
Review Comment:
Thank you very much for your help reviewing the code, I will modify the code.
> Improve Yarn Router Reservation Submission Code
> -----------------------------------------------
>
> Key: YARN-11297
> URL: https://issues.apache.org/jira/browse/YARN-11297
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: federation
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
>
> The same reservation may be submitted repeatedly. At this time, we should use
> the reserved results first. If the reserved results are not available,
> consider applying from other RMs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]