[ 
https://issues.apache.org/jira/browse/YARN-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602880#comment-17602880
 ] 

ASF GitHub Bot commented on YARN-7614:
--------------------------------------

slfan1989 commented on code in PR #4843:
URL: https://github.com/apache/hadoop/pull/4843#discussion_r967845912


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestRouterWebServicesREST.java:
##########
@@ -198,6 +202,7 @@ public Boolean get() {
         }
       }, 1000, 10 * 1000);
     } catch (Exception e) {
+      LOG.error("Web app not running", e);

Review Comment:
   > Why do we do this? Isn't it clear enough with the "fail()" message?
   
   I understand your thoughts, you are right, the  "fail()" message is enough, 
generally it is caused by timeout, I increased the timeout.





> [RESERVATION] Support ListReservation APIs in Federation Router
> ---------------------------------------------------------------
>
>                 Key: YARN-7614
>                 URL: https://issues.apache.org/jira/browse/YARN-7614
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: federation, reservation system
>            Reporter: Carlo Curino
>            Assignee: fanshilun
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to