[
https://issues.apache.org/jira/browse/YARN-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605927#comment-17605927
]
ASF GitHub Bot commented on YARN-11226:
---------------------------------------
goiri commented on code in PR #4892:
URL: https://github.com/apache/hadoop/pull/4892#discussion_r973215999
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestFederationInterceptorREST.java:
##########
@@ -142,6 +154,23 @@ public void setUp() {
Assert.fail();
}
+ try {
+ for (SubClusterId subCluster : subClusters) {
+ SubClusterInfo subClusterInfo =
stateStoreUtil.querySubClusterInfo(subCluster);
+ interceptor.getOrCreateInterceptorForSubCluster(
+ subCluster, subClusterInfo.getRMWebServiceAddress());
+ }
+ } catch (YarnException e) {
+ LOG.error(e.getMessage());
+ Assert.fail();
+ }
+
+ try {
+ interceptor.setupResourceManager();
+ } catch (Exception e) {
Review Comment:
Surfacing the exception would be enough
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestFederationInterceptorREST.java:
##########
@@ -142,6 +154,23 @@ public void setUp() {
Assert.fail();
}
+ try {
+ for (SubClusterId subCluster : subClusters) {
+ SubClusterInfo subClusterInfo =
stateStoreUtil.querySubClusterInfo(subCluster);
+ interceptor.getOrCreateInterceptorForSubCluster(
+ subCluster, subClusterInfo.getRMWebServiceAddress());
+ }
+ } catch (YarnException e) {
Review Comment:
Why isn't enough to surface the exception?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestableFederationInterceptorREST.java:
##########
@@ -51,4 +70,48 @@ protected void registerBadSubCluster(SubClusterId badSC) {
interceptor.setRunning(false);
}
+ protected void setupResourceManager() throws IOException {
+ try {
+ if (mockRM != null) {
+ return;
+ }
+
+ DefaultMetricsSystem.setMiniClusterMode(true);
+ CapacitySchedulerConfiguration conf = new
CapacitySchedulerConfiguration();
+
+ // Define default queue
+ conf.setCapacity(QUEUE_DEFAULT_FULL, 20);
+ // Define dedicated queues
+ conf.setQueues(CapacitySchedulerConfiguration.ROOT,
Review Comment:
Single line
> [Federation] Add createNewReservation, submitReservation, updateReservation,
> deleteReservation REST APIs for Router
> -------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-11226
> URL: https://issues.apache.org/jira/browse/YARN-11226
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation
> Affects Versions: 3.4.0, 3.3.4
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
