[ 
https://issues.apache.org/jira/browse/YARN-11238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607681#comment-17607681
 ] 

ASF GitHub Bot commented on YARN-11238:
---------------------------------------

slfan1989 commented on code in PR #4904:
URL: https://github.com/apache/hadoop/pull/4904#discussion_r976352674


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:
##########
@@ -728,6 +729,18 @@ public FederationStateStore getStateStore() {
   }
 
   /**
+   * Get Active's SubClusterIds{@link SubClusterId}.
+   *
+   * @return SubClusterId Collection.
+   * @throws YarnException if the call to get active subClusterIds is 
unsuccessful
+   */
+  public Collection<SubClusterId> getActiveSubClusterIds() throws 
YarnException {
+    Map<SubClusterId, SubClusterInfo> activeSubClusters =
+        getSubClusters(true);

Review Comment:
   Thanks for your suggestion, I will use the `getSubClusters` method.  The way 
of using parameters (true) is better for code understanding.





> Optimizing FederationClientInterceptor Call with Parallelism
> ------------------------------------------------------------
>
>                 Key: YARN-11238
>                 URL: https://issues.apache.org/jira/browse/YARN-11238
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: federation
>    Affects Versions: 3.4.0, 3.3.4
>            Reporter: fanshilun
>            Assignee: fanshilun
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to