[ 
https://issues.apache.org/jira/browse/YARN-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608621#comment-17608621
 ] 

ASF GitHub Bot commented on YARN-11294:
---------------------------------------

slfan1989 commented on code in PR #4915:
URL: https://github.com/apache/hadoop/pull/4915#discussion_r978381284


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java:
##########
@@ -40,50 +40,7 @@
 import org.apache.hadoop.yarn.server.federation.store.FederationStateStore;
 import 
org.apache.hadoop.yarn.server.federation.store.exception.FederationStateStoreInvalidInputException;
 import 
org.apache.hadoop.yarn.server.federation.store.metrics.FederationStateStoreClientMetrics;
-import 
org.apache.hadoop.yarn.server.federation.store.records.AddApplicationHomeSubClusterRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.AddApplicationHomeSubClusterResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.ApplicationHomeSubCluster;
-import 
org.apache.hadoop.yarn.server.federation.store.records.DeleteApplicationHomeSubClusterRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.DeleteApplicationHomeSubClusterResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetApplicationHomeSubClusterRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetApplicationHomeSubClusterResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetApplicationsHomeSubClusterRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetApplicationsHomeSubClusterResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterInfoRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterInfoResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterPoliciesConfigurationsRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterPoliciesConfigurationsResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterPolicyConfigurationRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterPolicyConfigurationResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetSubClustersInfoRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetSubClustersInfoResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.SetSubClusterPolicyConfigurationRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.SetSubClusterPolicyConfigurationResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.SubClusterDeregisterRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.SubClusterDeregisterResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.SubClusterHeartbeatRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.SubClusterHeartbeatResponse;
-import org.apache.hadoop.yarn.server.federation.store.records.SubClusterId;
-import org.apache.hadoop.yarn.server.federation.store.records.SubClusterInfo;
-import 
org.apache.hadoop.yarn.server.federation.store.records.SubClusterPolicyConfiguration;
-import 
org.apache.hadoop.yarn.server.federation.store.records.SubClusterRegisterRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.SubClusterRegisterResponse;
-import org.apache.hadoop.yarn.server.federation.store.records.SubClusterState;
-import 
org.apache.hadoop.yarn.server.federation.store.records.UpdateApplicationHomeSubClusterRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.UpdateApplicationHomeSubClusterResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.AddReservationHomeSubClusterRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.AddReservationHomeSubClusterResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetReservationHomeSubClusterResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetReservationHomeSubClusterRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetReservationsHomeSubClusterResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.GetReservationsHomeSubClusterRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.DeleteReservationHomeSubClusterRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.DeleteReservationHomeSubClusterResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.UpdateReservationHomeSubClusterRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.UpdateReservationHomeSubClusterResponse;
-import 
org.apache.hadoop.yarn.server.federation.store.records.ReservationHomeSubCluster;
-import 
org.apache.hadoop.yarn.server.federation.store.records.RouterMasterKeyRequest;
-import 
org.apache.hadoop.yarn.server.federation.store.records.RouterMasterKeyResponse;
+import org.apache.hadoop.yarn.server.federation.store.records.*;

Review Comment:
   I will fix it.





> [Federation] Router Support DelegationToken 
> storeNewToken/updateStoredToken/removeStoredToken With MemoryStateStore
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-11294
>                 URL: https://issues.apache.org/jira/browse/YARN-11294
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: federation
>    Affects Versions: 3.4.0
>            Reporter: fanshilun
>            Assignee: fanshilun
>            Priority: Major
>              Labels: pull-request-available
>
> Support storing storeNewToken/updateStoredToken/removeStoredToken in 
> MemoryStore mode.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to