[
https://issues.apache.org/jira/browse/YARN-11323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611312#comment-17611312
]
ASF GitHub Bot commented on YARN-11323:
---------------------------------------
slfan1989 commented on code in PR #4954:
URL: https://github.com/apache/hadoop/pull/4954#discussion_r984128757
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java:
##########
@@ -1054,4 +1060,24 @@ private void copyPlacementQueueToSubmissionContext(
context.setQueue(placementContext.getQueue());
}
}
+
+ @VisibleForTesting
+ public void setFederationStateStoreService(FederationStateStoreService
stateStoreService) {
+ this.federationStateStoreService = stateStoreService;
+ }
+
+ private void removeApplicationIdFromStateStore(ApplicationId applicationId) {
+ if (HAUtil.isFederationEnabled(conf) && federationStateStoreService !=
null) {
+ try {
+ DeleteApplicationHomeSubClusterResponse response =
+
federationStateStoreService.cleanUpFinishApplicationsWithRetries(applicationId);
+ if (response != null) {
+ LOG.info("applicationId = {} remove from state store success.",
+ applicationId);
Review Comment:
Thank you very much for your help reviewing the code, I will fix it.
> [Federation] Improve Router Handler FinishApps
> ----------------------------------------------
>
> Key: YARN-11323
> URL: https://issues.apache.org/jira/browse/YARN-11323
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: federation, router, yarn
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
