[
https://issues.apache.org/jira/browse/YARN-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinod Kumar Vavilapalli updated YARN-1481:
------------------------------------------
Attachment: YARN-1481-20131209.txt
Thanks Karthik.
bq. HAServiceStatus returned by getServiceStatus() has an isReadyToBecomeActive
method which is used by the FailoverController to check if an RM is in a state
to become Active. This corresponds to Active and Standby states, as the RM can
not be made Active when it is in the INITIALIZING or STOPPING states.
I see. Will become clear to me once I see the FOC code. Dropping the TODO now.
bq. .... Long story short, it can be removed.
Done, removed.
bq. I am not sure why we need a lock there in the first place. It should be
safe to remove it here, as transitionToStandby itself is synchronized.
That was my question too. I just copied code and there was a lock on
adminService there before.
bq. Comments on the patch itself:
Took care of them. Overall, I put up a raw patch quickly to run it by you to be
sure I am sure I not stepping toes.
> ResourceManager and AdminService interact in a convoluted manner after
> YARN-1318
> --------------------------------------------------------------------------------
>
> Key: YARN-1481
> URL: https://issues.apache.org/jira/browse/YARN-1481
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Vinod Kumar Vavilapalli
> Attachments: YARN-1481-20131207.txt, YARN-1481-20131209.txt
>
>
> This is something I found while reviewing YARN-1318, but didn't halt that
> patch as many cycles went there already. Some top level issues
> - Not easy to follow RM's service life cycle
> -- RM adds only AdminService as its service directly.
> -- Other services are added to RM when AdminService's init calls
> RM.activeServices.init()
> - Overall, AdminService shouldn't encompass all of RM's HA state management.
> It was originally supposed to be the implementation of just the RPC server.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
