[
https://issues.apache.org/jira/browse/YARN-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844127#comment-13844127
]
Karthik Kambatla commented on YARN-1481:
----------------------------------------
Thanks [~vinodkv]. The patch looks good to me. One minor nit:
{{AdminService#isRMActive()}} need not be synchronized. I am okay with
addressing the nit in another HA JIRA - may be, YARN-1029.
+1, otherwise. Will wait for any comments until end of the day and commit it.
> ResourceManager and AdminService interact in a convoluted manner after
> YARN-1318
> --------------------------------------------------------------------------------
>
> Key: YARN-1481
> URL: https://issues.apache.org/jira/browse/YARN-1481
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Vinod Kumar Vavilapalli
> Attachments: YARN-1481-20131207.txt, YARN-1481-20131209.txt
>
>
> This is something I found while reviewing YARN-1318, but didn't halt that
> patch as many cycles went there already. Some top level issues
> - Not easy to follow RM's service life cycle
> -- RM adds only AdminService as its service directly.
> -- Other services are added to RM when AdminService's init calls
> RM.activeServices.init()
> - Overall, AdminService shouldn't encompass all of RM's HA state management.
> It was originally supposed to be the implementation of just the RPC server.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
