[
https://issues.apache.org/jira/browse/YARN-10959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637151#comment-17637151
]
Peter Szucs edited comment on YARN-10959 at 11/22/22 10:32 AM:
---------------------------------------------------------------
We saw that extracting wouldn't provide us a real benefit here because of the
size of the duplication and the difference in the logic, so as per our
discussion with [~snemeth] I close this ticket.
was (Author: JIRAUSER297340):
We saw that extracting wouldn't provide us a real benefit here because of the
size of the duplication and the difference in the logic, ** so as per our
discussion with [~snemeth] I close this ticket.
> Extract common method of two that check if preemption disabled in
> CSQueuePreemption
> -----------------------------------------------------------------------------------
>
> Key: YARN-10959
> URL: https://issues.apache.org/jira/browse/YARN-10959
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Szilard Nemeth
> Assignee: Peter Szucs
> Priority: Minor
>
> This is a follow-up of YARN-10913.
> After YARN-10913, we have a class called CSQueuePreemption that has 2 methods
> that are very similar to each other:
> - isQueueHierarchyPreemptionDisabled
> - isIntraQueueHierarchyPreemptionDisabled
> The goal is to create one method and use it from those 2, merging the common
> logic as much as we can.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
