[
https://issues.apache.org/jira/browse/YARN-11349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643362#comment-17643362
]
ASF GitHub Bot commented on YARN-11349:
---------------------------------------
steveloughran commented on code in PR #5169:
URL: https://github.com/apache/hadoop/pull/5169#discussion_r1039646312
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/security/RouterDelegationTokenSecretManager.java:
##########
@@ -137,6 +141,29 @@ public void storeNewToken(RMDelegationTokenIdentifier
identifier,
}
}
+ /**
+ * The Router Supports Store new Token.
+ *
+ * @param identifier RMDelegationToken.
+ * @param tokenInfo DelegationTokenInformation.
+ */
+ public void storeNewToken(RMDelegationTokenIdentifier identifier,
+ DelegationTokenInformation tokenInfo) {
+ try {
+ String token =
+
RouterDelegationTokenSupport.encodeDelegationTokenInformation(tokenInfo);
+ long renewDate = tokenInfo.getRenewDate();
+
+ federationFacade.storeNewToken(identifier, renewDate, token);
+ } catch (Exception e) {
+ if (!shouldIgnoreException(e)) {
+ LOG.error("Error in storing RMDelegationToken with sequence number:
{}.",
+ identifier.getSequenceNumber());
+ ExitUtil.terminate(1, e);
Review Comment:
this really what should be done?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/security/token/delegation/RouterDelegationTokenSupport.java:
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.security.token.delegation;
+
+import org.apache.hadoop.io.WritableUtils;
+import
org.apache.hadoop.security.token.delegation.AbstractDelegationTokenSecretManager.DelegationTokenInformation;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.util.Base64;
+
+/**
+ * Workaround for serialization of {@link DelegationTokenInformation} through
package access.
+ * Future version of Hadoop should add this to DelegationTokenInformation
itself.
+ */
+public final class RouterDelegationTokenSupport {
+
+ private RouterDelegationTokenSupport() {
+ }
+
+ public static String
encodeDelegationTokenInformation(DelegationTokenInformation token) {
+ try {
+ ByteArrayOutputStream bos = new ByteArrayOutputStream();
+ DataOutputStream out = new DataOutputStream(bos);
+ WritableUtils.writeVInt(out, token.password.length);
+ out.write(token.password);
+ out.writeLong(token.renewDate);
+ out.flush();
+ byte[] tokenInfoBytes = bos.toByteArray();
+ return Base64.getUrlEncoder().encodeToString(tokenInfoBytes);
+ } catch (IOException ex) {
+ throw new RuntimeException("Failed to encode token.", ex);
Review Comment:
throw UncheckedIOException; add ex.toString() to message. its pretty
unlikely to happen here, but best practice
> [Federation] Router Support DelegationToken With SQL
> ----------------------------------------------------
>
> Key: YARN-11349
> URL: https://issues.apache.org/jira/browse/YARN-11349
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation, router
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> Router Support DelegationToken With SQLFederationStateStore.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
