[
https://issues.apache.org/jira/browse/YARN-11349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644767#comment-17644767
]
ASF GitHub Bot commented on YARN-11349:
---------------------------------------
slfan1989 commented on code in PR #5169:
URL: https://github.com/apache/hadoop/pull/5169#discussion_r1043268799
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/sql/FederationQueryRunner.java:
##########
@@ -0,0 +1,174 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.federation.store.sql;
+
+import org.apache.hadoop.classification.VisibleForTesting;
+
+import java.sql.Connection;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.sql.CallableStatement;
+import java.util.Arrays;
+
+/**
+ * QueryRunner is used to execute stored procedure SQL and parse the returned
results.
+ */
+public class FederationQueryRunner {
+
+ /**
+ * Execute Stored Procedure SQL.
+ *
+ * @param conn Database Connection.
+ * @param procedure Stored Procedure SQL.
+ * @param rsh Result Set handler.
+ * @param params List of stored procedure parameters.
+ * @param <T> Generic T.
+ * @return Stored Procedure Result Set.
+ * @throws SQLException An exception occurred when calling a stored
procedure.
+ */
+ public <T> T execute(Connection conn, String procedure, ResultSetHandler<T>
rsh, Object... params)
+ throws SQLException {
+ if (conn == null) {
+ throw new SQLException("Null connection");
+ }
+
+ if (procedure == null) {
+ throw new SQLException("Null Procedure SQL statement");
+ }
+
+ if (rsh == null) {
+ throw new SQLException("Null ResultSetHandler");
+ }
+
+ CallableStatement stmt = null;
+ T results = null;
+
+ try {
+ stmt = this.getCallableStatement(conn, procedure);
+ this.fillStatement(stmt, params);
+ stmt.executeUpdate();
+ this.retrieveOutParameters(stmt, params);
+ results = rsh.handle(params);
+ } catch (SQLException e) {
+ this.rethrow(e, procedure, params);
+ } finally {
+ close(stmt);
+ }
+ return results;
+ }
+
+ /**
+ * Get CallableStatement from Conn.
+ *
+ * @param conn Database Connection.
+ * @param procedure Stored Procedure SQL.
+ * @return CallableStatement.
+ * @throws SQLException An exception occurred when calling a stored
procedure.
+ */
+ @VisibleForTesting
+ protected CallableStatement getCallableStatement(Connection conn, String
procedure)
+ throws SQLException {
+ return conn.prepareCall(procedure);
+ }
+
+ /**
+ * Set Statement parameters.
+ *
+ * @param stmt CallableStatement.
+ * @param params Stored procedure parameters.
+ * @throws SQLException An exception occurred when calling a stored
procedure.
+ */
+ public void fillStatement(CallableStatement stmt, Object... params)
+ throws SQLException {
+ for (int i = 0; i < params.length; i++) {
+ if (params[i] != null) {
+ if (stmt != null) {
+ if (params[i] instanceof FederationSQLOutParameter) {
+ FederationSQLOutParameter sqlOutParameter =
(FederationSQLOutParameter) params[i];
+ sqlOutParameter.register(stmt, i + 1);
+ } else {
+ stmt.setObject(i + 1, params[i]);
+ }
+ }
+ }
+ }
+ }
+
+ /**
+ * Close Statement.
+ *
+ * @param stmt CallableStatement.
+ * @throws SQLException An exception occurred when calling a stored
procedure.
+ */
+ public void close(Statement stmt) throws SQLException {
+ if (stmt != null) {
+ stmt.close();
Review Comment:
I will fix it.
> [Federation] Router Support DelegationToken With SQL
> ----------------------------------------------------
>
> Key: YARN-11349
> URL: https://issues.apache.org/jira/browse/YARN-11349
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation, router
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> Router Support DelegationToken With SQLFederationStateStore.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
